refactor(express): add union operationId types to handleDecrypt and h…#8631
Merged
rishikeshdadam136 merged 1 commit intomasterfrom Apr 27, 2026
Merged
refactor(express): add union operationId types to handleDecrypt and h…#8631rishikeshdadam136 merged 1 commit intomasterfrom
rishikeshdadam136 merged 1 commit intomasterfrom
Conversation
…andleEncrypt handlers TICKET: WCI-234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET-234
Context - https://bitgo.slack.com/archives/C057BHBRG4B/p1764020095794829?thread_ts=1764018507.602879&cid=C057BHBRG4B
Summary
Why this matters
Without the union type, TypeScript only validates the handler against the v2 schema. If v1 and v2 schemas ever diverge (e.g. different request body fields), the v1 registration would silently accept a handler that is only type-safe for v2, leading to potential runtime bugs with no compile-time warning.
Both the end points are splitted in these pr's:#8560
#8553