Merging visionos branch into main#87
Merged
aure merged 21 commits intoAudioKit:mainfrom Apr 20, 2024
Merged
Conversation
Co-Authored-By: Aurelius Prochazka <aure@aure.com>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| let size = layer.drawableSize | ||
| let w = Float(size.width) | ||
| let h = Float(size.height) |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'h' (identifier_name)
| updateWaveform(samples: dataCallback()) | ||
|
|
||
| let size = layer.drawableSize | ||
| let w = Float(size.width) |
There was a problem hiding this comment.
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'w' (identifier_name)
| func draw(to layer: CAMetalLayer) { | ||
|
|
||
| updateWaveform(samples: dataCallback()) | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| layerRenderPassDescriptor = MTLRenderPassDescriptor() | ||
| layerRenderPassDescriptor.colorAttachments[0].loadAction = .clear | ||
| layerRenderPassDescriptor.colorAttachments[0].storeAction = .store | ||
| layerRenderPassDescriptor.colorAttachments[0].clearColor = MTLClearColorMake(0, 0, 0, 0); |
There was a problem hiding this comment.
Trailing Semicolon Violation: Lines should not have trailing semicolons. (trailing_semicolon)
| } | ||
|
|
||
| var metalLayer: CAMetalLayer { | ||
| layer as! CAMetalLayer |
There was a problem hiding this comment.
Force Cast Violation: Force casts should be avoided. (force_cast)
aure
approved these changes
Apr 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did some testing and merging vision os changes into main is safe to do, please merge.