Skip to content

Leave JSON encoding to HTTPX #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volodymyrZotov merged 1 commit into from
Jan 5, 2024
Merged

Leave JSON encoding to HTTPX #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/onepasswordconnectsdk/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Python AsyncClient for connecting to 1Password Connect"""
import httpx
from httpx import HTTPError
import json
from typing import Dict, List, Union
import os

Expand Down Expand Up @@ -361,8 +360,8 @@ def build_request(self, method: str, path: str, body=None) -> httpx.Response:
"""

if body:
serialized_body = json.dumps(self.serializer.sanitize_for_serialization(body))
response = self.session.request(method, path, data=serialized_body)
sanitized_body = self.serializer.sanitize_for_serialization(body)
response = self.session.request(method, path, json=sanitized_body)
else:
response = self.session.request(method, path)
return response
Expand Down
4 changes: 2 additions & 2 deletions src/onepasswordconnectsdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,8 @@ def build_request(self, method: str, path: str, body=None) -> httpx.Response:
"""

if body:
serialized_body = json.dumps(self.serializer.sanitize_for_serialization(body))
response = self.session.request(method, path, data=serialized_body)
sanitized_body = self.serializer.sanitize_for_serialization(body)
response = self.session.request(method, path, json=sanitized_body)
else:
response = self.session.request(method, path)
return response
Expand Down