Skip to content

fix: correctly handle section objects with None type labels #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpcoenen merged 1 commit into from
Dec 2, 2022
Merged

fix: correctly handle section objects with None type labels #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/onepasswordconnectsdk/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,17 +193,20 @@ def _set_values_for_item(
section_id = field.section.id
except AttributeError:
section_id = None

if field.label == path_parts[1] and (
section_id is None or section_id == sections[path_parts[0]]
):
value_found = True

if config_object:
setattr(config_object, parsed_field.name, field.value)
else:
config_dict[parsed_field.name] = field.value
break

if field.label == path_parts[1]:
if (
section_id is None
or (section_id == sections.get(path_parts[0]))
or path_parts[0] in sections.values()
):
value_found = True

if config_object:
setattr(config_object, parsed_field.name, field.value)
else:
config_dict[parsed_field.name] = field.value
break
if not value_found:
raise UnknownSectionAndFieldTag(
f"There is no section {path_parts[0]} \
Expand All @@ -214,6 +217,7 @@ def _set_values_for_item(
def _convert_sections_to_dict(sections: List[Section]):
if not sections:
return {}

section_dict = {section.label: section.id for section in sections}
return section_dict

Expand Down