refactor(crypto): remove unused web3j-era helpers from WalletUtils

The following methods had no production callers after the keystore
refactor — the only reference was a coverage-padding test at
SupplementTest.testGet (no assertions, just "call these to bump the
coverage number") plus internal self-references:

- generateFullNewWalletFile(String, File, boolean)
- generateLightNewWalletFile(String, File, boolean)
- generateNewWalletFile(String, File, boolean, boolean)
- getDefaultKeyDirectory() / getDefaultKeyDirectory(String)
- getTestnetKeyDirectory()
- getMainnetKeyDirectory()

The three generate* wrappers were identical calls into the real
generateWalletFile(String, SignInterface, File, boolean) (which is kept
and actively used). The three getDirectory helpers returned Ethereum-
style paths (~/Library/Ethereum, %APPDATA%/Ethereum, ~/.ethereum) —
hard-coded from the web3j origin of this code, never applicable in a
TRON context, and capable of misleading anyone who tried to use them.

Also drops the corresponding five noop invocations from
SupplementTest.testGet and its now-unused WalletUtils import (the
static import of passwordValid elsewhere in the file is preserved —
it's still exercised by testPasswordValid).

No production behavior change. Reduces the crypto module's public API
surface and keeps the keystore library focused on what TRON actually
uses.

Author: Barbatos

crypto/src/main/java/org/tron/keystore/WalletUtils.java

@@ -12,9 +12,6 @@
 import java.nio.file.StandardCopyOption;
 import java.nio.file.attribute.PosixFilePermission;
 import java.nio.file.attribute.PosixFilePermissions;
-import java.security.InvalidAlgorithmParameterException;
-import java.security.NoSuchAlgorithmException;
-import java.security.NoSuchProviderException;
 import java.time.ZoneOffset;
 import java.time.ZonedDateTime;
 import java.time.format.DateTimeFormatter;
@@ -24,8 +21,6 @@
 import java.util.Set;
 import org.apache.commons.lang3.StringUtils;
 import org.tron.common.crypto.SignInterface;
-import org.tron.common.crypto.SignUtils;
-import org.tron.common.utils.Utils;
 import org.tron.core.exception.CipherException;
 
 /**
@@ -44,31 +39,6 @@ public class WalletUtils {
     objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
   }
 
-  public static String generateFullNewWalletFile(String password, File destinationDirectory,
-      boolean ecKey)
-      throws NoSuchAlgorithmException, NoSuchProviderException,
-      InvalidAlgorithmParameterException, CipherException, IOException {
-
-    return generateNewWalletFile(password, destinationDirectory, true, ecKey);
-  }
-
-  public static String generateLightNewWalletFile(String password, File destinationDirectory,
-      boolean ecKey)
-      throws NoSuchAlgorithmException, NoSuchProviderException,
-      InvalidAlgorithmParameterException, CipherException, IOException {
-
-    return generateNewWalletFile(password, destinationDirectory, false, ecKey);
-  }
-
-  public static String generateNewWalletFile(
-      String password, File destinationDirectory, boolean useFullScrypt, boolean ecKey)
-      throws CipherException, IOException, InvalidAlgorithmParameterException,
-      NoSuchAlgorithmException, NoSuchProviderException {
-
-    SignInterface ecKeyPair = SignUtils.getGeneratedRandomSign(Utils.getRandom(), ecKey);
-    return generateWalletFile(password, ecKeyPair, destinationDirectory, useFullScrypt);
-  }
-
   public static String generateWalletFile(
       String password, SignInterface ecKeyPair, File destinationDirectory, boolean useFullScrypt)
       throws CipherException, IOException {
@@ -159,33 +129,6 @@ public static String getWalletFileName(WalletFile walletFile) {
     return now.format(format) + walletFile.getAddress() + ".json";
   }
 
-  public static String getDefaultKeyDirectory() {
-    return getDefaultKeyDirectory(System.getProperty("os.name"));
-  }
-
-  static String getDefaultKeyDirectory(String osName1) {
-    String osName = osName1.toLowerCase();
-
-    if (osName.startsWith("mac")) {
-      return String.format(
-          "%s%sLibrary%sEthereum", System.getProperty("user.home"), File.separator,
-          File.separator);
-    } else if (osName.startsWith("win")) {
-      return String.format("%s%sEthereum", System.getenv("APPDATA"), File.separator);
-    } else {
-      return String.format("%s%s.ethereum", System.getProperty("user.home"), File.separator);
-    }
-  }
-
-  public static String getTestnetKeyDirectory() {
-    return String.format(
-        "%s%stestnet%skeystore", getDefaultKeyDirectory(), File.separator, File.separator);
-  }
-
-  public static String getMainnetKeyDirectory() {
-    return String.format("%s%skeystore", getDefaultKeyDirectory(), File.separator);
-  }
-
   /**
    * Strip trailing line terminators ({@code \n}/{@code \r}) and a leading
    * UTF-8 BOM ({@code \uFEFF}) from a line of input. Unlike

framework/src/test/java/org/tron/program/SupplementTest.java

@@ -27,7 +27,6 @@
 import org.tron.core.config.args.Args;
 import org.tron.core.services.http.HttpSelfFormatFieldName;
 import org.tron.core.store.StorageRowStore;
-import org.tron.keystore.WalletUtils;
 
 public class SupplementTest extends BaseTest {
 
@@ -54,12 +53,6 @@ public void testGet() throws Exception {
     String p = dbPath + File.separator;
     dbBackupConfig.initArgs(true, p + "propPath", p + "bak1path/", p + "bak2path/", 1);
 
-    WalletUtils.generateFullNewWalletFile("123456", new File(dbPath), true);
-    WalletUtils.generateLightNewWalletFile("123456", new File(dbPath), true);
-    WalletUtils.getDefaultKeyDirectory();
-    WalletUtils.getTestnetKeyDirectory();
-    WalletUtils.getMainnetKeyDirectory();
-
     Value value = new Value(new byte[]{1});
     value.asBytes();
     value = new Value(1);