From 2388e65ae9e7b91993c2fed905d27d1d90776beb Mon Sep 17 00:00:00 2001 From: Luciano Martorella Date: Tue, 13 Jul 2021 16:43:19 +0200 Subject: [PATCH 1/2] - Added minimize keyword - Added atest --- atest/acceptance/windows.robot | 24 ++++++++++++++++++++++++ src/SeleniumLibrary/keywords/window.py | 5 +++++ 2 files changed, 29 insertions(+) diff --git a/atest/acceptance/windows.robot b/atest/acceptance/windows.robot index b9a6c5d38..7bcf9fdf8 100644 --- a/atest/acceptance/windows.robot +++ b/atest/acceptance/windows.robot @@ -108,6 +108,30 @@ Set Window Position using strings Should Be Equal ${x} ${200} Should Be Equal ${y} ${100} +Test Minimize and Maximize Will Actually Move and Resize Window + Set Window Position 300 200 + Set Window Size 400 300 + ${isHidden}= Execute Javascript return document.hidden; + Should Not Be True ${isHidden} + + Minimize Browser Window + + ${isHidden}= Execute Javascript return document.hidden; + Should Be True ${isHidden} + + Maximize Browser Window + + ${isHidden}= Execute Javascript return document.hidden; + Should Not Be True ${isHidden} + + ${x} ${y}= Get Window Position + ${width} ${height}= Get Window Size + # Windows: Can't test for zero in multi-monitor setups + Should Not Be Equal ${x} ${300} + Should Not Be Equal ${y} ${200} + Should Be True ${width} > 400 + Should Be True ${height} > 300 + Select Window By Title After Close Window [Tags] Known Issue Internet Explorer Known Issue Safari Cannot Be Executed in IE diff --git a/src/SeleniumLibrary/keywords/window.py b/src/SeleniumLibrary/keywords/window.py index 43588d7d5..01feee1fe 100644 --- a/src/SeleniumLibrary/keywords/window.py +++ b/src/SeleniumLibrary/keywords/window.py @@ -186,6 +186,11 @@ def maximize_browser_window(self): """Maximizes current browser window.""" self.driver.maximize_window() + @keyword + def minimize_browser_window(self): + """Minimizes current browser window.""" + self.driver.minimize_window() + @keyword def get_window_size(self, inner: bool = False) -> Tuple[float, float]: """Returns current window width and height as integers. From 994a13885276a0931c1aac358700f78dab7c9c4b Mon Sep 17 00:00:00 2001 From: Luciano Martorella Date: Fri, 29 Jul 2022 17:28:17 +0200 Subject: [PATCH 2/2] - Fixed kw count --- utest/test/api/test_plugins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utest/test/api/test_plugins.py b/utest/test/api/test_plugins.py index 7218e637b..fd4d06ff4 100644 --- a/utest/test/api/test_plugins.py +++ b/utest/test/api/test_plugins.py @@ -22,7 +22,7 @@ def setUpClass(cls): def test_no_libraries(self): for item in [None, "None", ""]: sl = SeleniumLibrary(plugins=item) - self.assertEqual(len(sl.get_keyword_names()), 173) + self.assertEqual(len(sl.get_keyword_names()), 174) def test_parse_library(self): plugin = "path.to.MyLibrary"