Skip to content

Upgrade to lerna@2.11, rebuild package-lock#579

Merged
shawnbot merged 5 commits intomasterfrom
fix-bootstrap
Oct 17, 2018
Merged

Upgrade to lerna@2.11, rebuild package-lock#579
shawnbot merged 5 commits intomasterfrom
fix-bootstrap

Conversation

@shawnbot
Copy link
Copy Markdown
Contributor

@shawnbot shawnbot commented Oct 15, 2018

This is an attempt to get Travis (and local!) bootstraps of the monorepo working again by:

  1. Upgrading to the latest 2.x release of Lerna (v2.11.0)
  2. Renaming the root package.json dependencies field from devDependencies to dependencies
  3. Rebuilding package-lock.json
  4. Running npm audit fix to deal with some security issues

🤞

/cc @primer/ds-core

@shawnbot shawnbot changed the title [WIP] Upgrade to lerna@2.11, rebuild package-lock Upgrade to lerna@2.11, rebuild package-lock Oct 15, 2018
@shawnbot
Copy link
Copy Markdown
Contributor Author

Okay, I've merged this into #556 and it appears to be working there. In the interest of making it easier to update other branches, I'd like to merge this to master. @jonrohan, you cool with that assuming it looks good otherwise?

Copy link
Copy Markdown
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t remember if there was a specific reason for putting the dependencies outside of dev, but it seemed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants