Wangbill/serverless private preview op1#734
Draft
YunchuWang wants to merge 30 commits into
Draft
Conversation
ServerlessActivitiesClientAdapter now takes an attachTaskHubMetadata flag (default true). The Azure-managed channel already injects the taskhub header via CallCredentials, so the AddDurableTaskScheduler* path constructs the adapter with attachTaskHubMetadata: false to avoid sending duplicate headers on DeclareServerlessActivities and ConnectServerlessActivityWorker. Added two unit tests with a recording CallInvoker covering both modes.
This reverts commit 18c8e02.
- Updated README.md to clarify remote worker image settings. - Simplified task hub retrieval in Program.cs. - Removed unnecessary endpoint configuration in remote worker. - Added Azure.Identity package reference in csproj. - Refined serverless worker extensions for environment configuration. - Updated serverless activity configuration to handle registered activities. - Modified tests to reflect changes in activity registration and filtering.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+246
to
+252
| foreach (DurableTaskWorkerWorkItemFilters.ActivityFilter filter in existingFilters) | ||
| { | ||
| if (!string.IsNullOrWhiteSpace(filter.Name)) | ||
| { | ||
| merged[filter.Name] = filter; | ||
| } | ||
| } |
Comment on lines
+224
to
+230
| foreach (string? value in values) | ||
| { | ||
| if (!string.IsNullOrWhiteSpace(value)) | ||
| { | ||
| return value.Trim(); | ||
| } | ||
| } |
Comment on lines
+224
to
+229
| catch (Exception ex) | ||
| { | ||
| Logs.ServerlessActivityWorkerRegistrationFailed(this.logger, ex, this.options.TaskHub); | ||
| await this.DelayBeforeReconnectAsync(retryDelay, cancellationToken).ConfigureAwait(false); | ||
| retryDelay = this.GetNextRetryDelay(retryDelay); | ||
| } |
Comment on lines
+260
to
+263
| catch (Exception) | ||
| { | ||
| // The server response is authoritative once the response task wins the race. | ||
| } |
Comment on lines
+109
to
+111
| catch (Exception ex) when (ex is OperationCanceledException or ObjectDisposedException or RpcException) | ||
| { | ||
| } |
Comment on lines
+120
to
+122
| catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested) | ||
| { | ||
| } |
Comment on lines
+123
to
+125
| catch (Exception ex) when (ex is OperationCanceledException or ObjectDisposedException or RpcException) | ||
| { | ||
| } |
Comment on lines
+176
to
+178
| catch (Exception ex) when (ex is OperationCanceledException or ObjectDisposedException or RpcException) | ||
| { | ||
| } |
Comment on lines
+257
to
+259
| catch (OperationCanceledException) when (heartbeatCts.IsCancellationRequested) | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed?
Why is this change needed?
Issues / work items
Project checklist
release_notes.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
AI verification (required if AI was used):
Testing
Automated tests
Manual validation (only if runtime/behavior changed)
1.
2.
3.
Notes for reviewers