diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml index e784069..732e47e 100644 --- a/.github/workflows/sonarcloud.yml +++ b/.github/workflows/sonarcloud.yml @@ -56,8 +56,8 @@ jobs: dotnet tool install --global dotnet-sonarscanner echo "$env:USERPROFILE\.dotnet\tools" >> $env:GITHUB_PATH dotnet sonarscanner begin ` - /k:"ppanchen_NetSdrClient" ` - /o:"ppanchen" ` + /k:"AntAndriy7_ReengineeringCourse" ` + /o:"antandriy7" ` /d:sonar.token="${{ secrets.SONAR_TOKEN }}" ` /d:sonar.cs.opencover.reportsPaths="**/coverage.xml" ` /d:sonar.cpd.cs.minimumTokens=40 ` diff --git a/NetSdrClientApp/NetSdrClient.cs b/NetSdrClientApp/NetSdrClient.cs index b0a7c05..afc24f8 100644 --- a/NetSdrClientApp/NetSdrClient.cs +++ b/NetSdrClientApp/NetSdrClient.cs @@ -4,6 +4,7 @@ using System.Collections.Generic; using System.Linq; using System.Text; +using System.IO; using System.Threading; using System.Threading.Channels; using System.Threading.Tasks; @@ -14,8 +15,10 @@ namespace NetSdrClientApp { public class NetSdrClient { - private ITcpClient _tcpClient; - private IUdpClient _udpClient; + private readonly ITcpClient _tcpClient; + private readonly IUdpClient _udpClient; + + private TaskCompletionSource? _responseTaskSource; public bool IQStarted { get; set; } @@ -131,8 +134,6 @@ private void _udpClient_MessageReceived(object? sender, byte[] e) } } - private TaskCompletionSource responseTaskSource; - private async Task SendTcpRequest(byte[] msg) { if (!_tcpClient.Connected) @@ -141,8 +142,8 @@ private async Task SendTcpRequest(byte[] msg) return null; } - responseTaskSource = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); - var responseTask = responseTaskSource.Task; + _responseTaskSource = new TaskCompletionSource(TaskCreationOptions.RunContinuationsAsynchronously); + var responseTask = _responseTaskSource.Task; await _tcpClient.SendMessageAsync(msg); @@ -154,10 +155,10 @@ private async Task SendTcpRequest(byte[] msg) private void _tcpClient_MessageReceived(object? sender, byte[] e) { //TODO: add Unsolicited messages handling here - if (responseTaskSource != null) + if (_responseTaskSource != null) { - responseTaskSource.SetResult(e); - responseTaskSource = null; + _responseTaskSource.SetResult(e); + _responseTaskSource = null; } Console.WriteLine("Response recieved: " + e.Select(b => Convert.ToString(b, toBase: 16)).Aggregate((l, r) => $"{l} {r}")); }