Skip to content
This repository was archived by the owner on Feb 13, 2026. It is now read-only.

Feat: Client should pass client_options.api_key to auth library#321

Merged
parthea merged 9 commits intomainfrom
api_key
Feb 13, 2025
Merged

Feat: Client should pass client_options.api_key to auth library#321
parthea merged 9 commits intomainfrom
api_key

Conversation

@andrewsg
Copy link
Copy Markdown
Contributor

Fixes #319 🦕

@andrewsg andrewsg requested a review from parthea February 11, 2025 01:04
@andrewsg andrewsg requested a review from a team February 11, 2025 01:04
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Feb 11, 2025
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 11, 2025
Copy link
Copy Markdown
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but holding off on formal approval until comments are addressed

Comment thread google/cloud/client/__init__.py Outdated
Comment thread google/cloud/client/__init__.py Outdated
Comment thread google/cloud/client/__init__.py Outdated
Comment thread setup.py Outdated
Comment thread testing/constraints-3.7.txt Outdated
Comment thread .kokoro/docker/docs/requirements.txt
@andrewsg
Copy link
Copy Markdown
Contributor Author

Thanks! Applied suggestions, PTAL.

@parthea parthea merged commit dfac15b into main Feb 13, 2025
@parthea parthea deleted the api_key branch February 13, 2025 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If api_key is set in client options, pass it through to auth

2 participants