From 72d9cc8f62cf6853f351a0c610d37d74c876b905 Mon Sep 17 00:00:00 2001
From: Adam Heinz <adam.heinz@metricwise.com>
Date: Mon, 7 Jul 2025 09:22:18 -0400
Subject: [PATCH] [FIX] queue_job: prevent conflict w/
 TestOverrides:test_creates

This prevents TestOverrides.test_creates from failing in the Odoo
`base` module due to sentinel protections taking effect even for
local create invocations.
---
 queue_job/models/queue_job.py                 |  7 +----
 .../tests/test_queue_job_protected_write.py   | 26 ++++++++++++++++---
 2 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/queue_job/models/queue_job.py b/queue_job/models/queue_job.py
index 465d5fd1d7..98c5858203 100644
--- a/queue_job/models/queue_job.py
+++ b/queue_job/models/queue_job.py
@@ -235,13 +235,8 @@ def _compute_graph_jobs_count(self):
             record.graph_jobs_count = count_per_graph_uuid.get(record.graph_uuid) or 0
 
     @api.model_create_multi
+    @api.private
     def create(self, vals_list):
-        if self.env.context.get("_job_edit_sentinel") is not self.EDIT_SENTINEL:
-            # Prevent to create a queue.job record "raw" from RPC.
-            # ``with_delay()`` must be used.
-            raise exceptions.AccessError(
-                _("Queue jobs must be created by calling 'with_delay()'.")
-            )
         return super(
             QueueJob,
             self.with_context(mail_create_nolog=True, mail_create_nosubscribe=True),
diff --git a/queue_job/tests/test_queue_job_protected_write.py b/queue_job/tests/test_queue_job_protected_write.py
index 018b3f23f4..eadb16ab9c 100644
--- a/queue_job/tests/test_queue_job_protected_write.py
+++ b/queue_job/tests/test_queue_job_protected_write.py
@@ -3,15 +3,33 @@
 
 from odoo import exceptions
 from odoo.tests import common
+from odoo.tools import mute_logger
 
 
-class TestJobWriteProtected(common.TransactionCase):
+class TestJobCreatePrivate(common.HttpCase):
     def test_create_error(self):
-        with self.assertRaises(exceptions.AccessError):
-            self.env["queue.job"].create(
-                {"uuid": "test", "model_name": "res.partner", "method_name": "write"}
+        self.authenticate("admin", "admin")
+        with self.assertRaises(common.JsonRpcException) as cm, mute_logger("odoo.http"):
+            self.make_jsonrpc_request(
+                "/web/dataset/call_kw",
+                params={
+                    "model": "queue.job",
+                    "method": "create",
+                    "args": [],
+                    "kwargs": {
+                        "method_name": "write",
+                        "model_name": "res.partner",
+                        "uuid": "test",
+                    },
+                },
+                headers={
+                    "Cookie": f"session_id={self.session.sid};",
+                },
             )
+        self.assertEqual("odoo.exceptions.AccessError", str(cm.exception))
 
+
+class TestJobWriteProtected(common.TransactionCase):
     def test_write_protected_field_error(self):
         job_ = self.env["res.partner"].with_delay().create({"name": "test"})
         db_job = job_.db_record()