fix: ensure api/static directory is created by Git#3702
Merged
Conversation
This prevents a warning starting the API if this directory does not exist:
/Users/rolodato/Library/Caches/pypoetry/virtualenvs/flagsmith-api-Avcq7jRJ-py3.11/lib/python3.11/site-packages/whitenoise/base.py:115: UserWarning: No directory at: /Users/rolodato/source/flagsmith/flagsmith/api/static/
warnings.warn(f"No directory at: {root}")
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
matthewelwell
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a warning starting the API if this directory does not exist:
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Adds a
.gitkeepfile that is allow-listed inapi/.gitignoreto ensure theapi/staticdirectory exists when cloning this repository. This prevents a warning when starting up the API and the directory does not yet exist.Before:
After:
How did you test this code?
Manually by cleaning all untracked files and directories in the repository, and checking that the
api/staticdirectory still exists: