Skip to content

fix: Adjust permissions logic for view / manage groups#3679

Merged
kyle-ssg merged 8 commits into
mainfrom
chore/show-groups-to-group-admin
Apr 8, 2024
Merged

fix: Adjust permissions logic for view / manage groups#3679
kyle-ssg merged 8 commits into
mainfrom
chore/show-groups-to-group-admin

Conversation

@kyle-ssg
Copy link
Copy Markdown
Member

@kyle-ssg kyle-ssg commented Mar 26, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Removes /projects in place of /organisation-settings (which has the projects tab)
  • Allows user to see the groups tab if they are admin of any groups

Note : This will need to be considered when refactoring groups to rtk

How did you test this code?

  • Create a new group
  • Make a standard org user without any permissions a group admin
  • Login as user, manage groups

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:28am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:28am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:28am

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Mar 26, 2024
# Conflicts:
#	frontend/web/components/pages/OrganisationSettingsPage.js
@kyle-ssg kyle-ssg marked this pull request as draft March 26, 2024 17:52
@kyle-ssg kyle-ssg changed the title Adjust permissions logic for view / manage groups fix: Adjust permissions logic for view / manage groups Mar 26, 2024
@kyle-ssg kyle-ssg requested review from khvn26 and novakzaballa March 26, 2024 17:56
@kyle-ssg kyle-ssg linked an issue Mar 26, 2024 that may be closed by this pull request
4 tasks
@kyle-ssg kyle-ssg marked this pull request as ready for review March 27, 2024 11:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2024

Uffizzi Preview deployment-49008 was deleted.

# Conflicts:
#	frontend/web/components/UserGroupList.tsx
@kyle-ssg kyle-ssg added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 5ba3083 Apr 8, 2024
@kyle-ssg kyle-ssg deleted the chore/show-groups-to-group-admin branch April 8, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group admins can't access Groups tab in organisation settings

2 participants