Add explicit signal disable controls#48
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThis PR adds OPENCODE_DISABLE_LOGS and OPENCODE_DISABLE_TRACES, computes logsEnabled and normalized disabledTraces at startup, provides a gated emitLog callback in OtelPlugin, updates handlers to call emitLog, and adds tests and README docs covering the new flags. ChangesLog and Trace Disablement Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 179-205: Add entries for the new "Disabling OTLP logs" and
"Disabling traces" sections to the top-level configuration TOC in README.md so
they are discoverable; update the TOC to include links that match the headings
(e.g., Disabling OTLP logs -> `#disabling-otlp-logs` and Disabling traces ->
`#disabling-traces`), place them near other configuration/env-var items, and
ensure the entries mention the related env vars OPENCODE_DISABLE_LOGS and
OPENCODE_DISABLE_TRACES for clarity.
In `@tests/config.test.ts`:
- Around line 270-283: Add a test asserting that OPENCODE_DISABLE_TRACES="1" is
treated as a global-disable alias: set
process.env["OPENCODE_DISABLE_TRACES"]="1" and expect
loadConfig().disabledTraces to equal new Set(TRACE_TYPES). This mirrors the
existing tests for "all", "*", and "true" and ensures parseDisabledTraces /
loadConfig handle the "1" alias as disabling every trace type.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0ba279a7-a881-4ffa-baee-1f7b476923c5
📒 Files selected for processing (11)
README.mdsrc/config.tssrc/handlers/activity.tssrc/handlers/message.tssrc/handlers/permission.tssrc/handlers/session.tssrc/index.tssrc/types.tstests/config.test.tstests/handlers/disabled-signals.test.tstests/helpers.ts
|
Can you resolve the conflicts on this? It looks good, I will merge as soon as you fix those. Thanks! |
|
Fixed, thank you for reviewing. |
Add explicit controls for suppressing OTLP log and trace export.
OPENCODE_DISABLE_LOGSto suppress every OTLP log event while leaving metrics and traces untouchedOPENCODE_DISABLE_TRACESsupport explicit global values such asall,*,true, and1Summary by CodeRabbit
New Features
all,*,true,1).Behavior Changes
Tests
Documentation